Skip to content

fix: enable typing #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Borda wants to merge 2 commits into from
Closed

fix: enable typing #571

Borda wants to merge 2 commits into from

Conversation

@Borda
Copy link
Contributor

@Borda Borda commented Nov 18, 2024 •
edited
Loading

seems typing with python 3.9+ does not work smoothly...

src/lightning_utilities/cli/__main__.py:5: error: Cannot find implementation or library stub for module named "fire"  [import-not-found]
src/lightning_utilities/cli/__main__.py:5: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
Found 1 error in 1 file (checked 19 source files)

ref: https://github.com/Lightning-AI/utilities/actions/runs/11898513780/job/33155190565?pr=331
cc: @dbieber

@Borda Borda mentioned this pull request Nov 18, 2024
Merged
3 tasks
@Borda
Copy link
Contributor Author

Borda commented Nov 25, 2024

@dbieber do you think we can roll out this typing fix? 🙏

@Borda
Copy link
Contributor Author

Borda commented Feb 11, 2025

@dbieber do you think we can roll out this typing fix? 🙏

@dbieber friendly ping if we shall land it or close it? :)

@Borda
Copy link
Contributor Author

Borda commented Jun 30, 2025

@dbieber, what is happening with the import/copybara?

@Borda Borda closed this Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Borda